Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: sky/sdk/lib/framework/components2/ink_well.dart

Issue 1162623011: Fix some minor warnings from the analyzer in the framework. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../fn2.dart'; 5 import '../fn2.dart';
6 import '../rendering/flex.dart'; 6 import '../rendering/flex.dart';
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:sky' as sky; 8 import 'dart:sky' as sky;
9 // import 'ink_splash.dart'; 9 // import 'ink_splash.dart';
10 import 'scrollable.dart'; 10 import 'scrollable.dart';
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 // _splashes.add(splash); 62 // _splashes.add(splash);
63 // UINode node = parent; 63 // UINode node = parent;
64 // while (node != null) { 64 // while (node != null) {
65 // if (node is Scrollable) 65 // if (node is Scrollable)
66 // node.registerScrollClient(this); 66 // node.registerScrollClient(this);
67 // node = node.parent; 67 // node = node.parent;
68 // } 68 // }
69 // }); 69 // });
70 // } 70 // }
71 71
72 // bool ancestorScrolled(Scrollable ancestor) { 72 bool ancestorScrolled(Scrollable ancestor) {
73 // _abortSplashes(); 73 // _abortSplashes();
74 // return false; 74 return false;
75 // } 75 }
76 76
77 // void handleRemoved() { 77 // void handleRemoved() {
78 // UINode node = parent; 78 // UINode node = parent;
79 // while (node != null) { 79 // while (node != null) {
80 // if (node is Scrollable) 80 // if (node is Scrollable)
81 // node.unregisterScrollClient(this); 81 // node.unregisterScrollClient(this);
82 // node = node.parent; 82 // node = node.parent;
83 // } 83 // }
84 // super.handleRemoved(); 84 // super.handleRemoved();
85 // } 85 // }
(...skipping 26 matching lines...) Expand all
112 // void _splashDone(SplashController splash) { 112 // void _splashDone(SplashController splash) {
113 // if (_splashes == null) 113 // if (_splashes == null)
114 // return; 114 // return;
115 // setState(() { 115 // setState(() {
116 // _splashes.remove(splash); 116 // _splashes.remove(splash);
117 // if (_splashes.length == 0) 117 // if (_splashes.length == 0)
118 // _splashes = null; 118 // _splashes = null;
119 // }); 119 // });
120 // } 120 // }
121 } 121 }
OLDNEW
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698