Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1162623011: Fix some minor warnings from the analyzer in the framework. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/ink_well.dart ('k') | sky/sdk/lib/framework/rendering/box.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 14c41e38783487ebb657a3e85b8df7c8b180fcda..fc9770624621cce7a70e2df720b7384c24c95299 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -463,6 +463,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
void insert(RenderObjectWrapper child, dynamic slot) {
assert(slot == null || slot is RenderObject);
+ assert(root is ContainerRenderObjectMixin);
root.add(child.root, before: slot);
}
@@ -648,6 +649,11 @@ class Paragraph extends RenderObjectWrapper {
super.syncRenderObject(old);
root.text = text;
}
+
+ void insert(RenderObjectWrapper child, dynamic slot) {
+ assert(false);
+ // Paragraph does not support having children currently
+ }
}
class FlexContainer extends MultiChildRenderObjectWrapper {
@@ -691,6 +697,11 @@ class Image extends RenderObjectWrapper {
root.src = src;
root.requestedSize = size;
}
+
+ void insert(RenderObjectWrapper child, dynamic slot) {
+ assert(false);
+ // Image does not support having children currently
+ }
}
« no previous file with comments | « sky/sdk/lib/framework/components2/ink_well.dart ('k') | sky/sdk/lib/framework/rendering/box.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698