Implement a simple checkbox in Sky’s fn2 components library

Implement a simple checkbox in Sky’s fn2 components library

R=abarth@chromium.org, abarth

Committed: https://chromium.googlesource.com/external/mojo/+/32fe72ec0ca7d3bc948a448d5a478c825907cbc3

[abarth-chromium, 2015-06-05 21:00:59]

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/Ca...
File sky/engine/core/painting/Canvas.h (right):

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/Ca...
sky/engine/core/painting/Canvas.h:46: void drawLine(float x0, float y0, float
x1, float y1, const Paint* paint);
Point p1, Point p2

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/RR...
File sky/engine/core/painting/RRect.idl (right):

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/RR...
sky/engine/core/painting/RRect.idl:8: void setRectXY(Rect rect, float xRad,
float yRad);
I was expecting this to be like Rect.dart, which is to say a Dart-native object
that coverts into an SkRRect

https://codereview.chromium.org/1161813005/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/checkbox.dart (right):

https://codereview.chromium.org/1161813005/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/checkbox.dart:40: paint.strokeWidth = 2.0;
Why not use the .. operator to set these values?

[jackson, 2015-06-05 21:14:12]

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/Ca...
File sky/engine/core/painting/Canvas.h (right):

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/Ca...
sky/engine/core/painting/Canvas.h:46: void drawLine(float x0, float y0, float
x1, float y1, const Paint* paint);
On 2015/06/05 21:00:59, abarth wrote:
> Point p1, Point p2

We might want to match the Skia APIs, I will land as is and ask mpcomplete what
he thinks

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/RR...
File sky/engine/core/painting/RRect.idl (right):

https://codereview.chromium.org/1161813005/diff/1/sky/engine/core/painting/RR...
sky/engine/core/painting/RRect.idl:8: void setRectXY(Rect rect, float xRad,
float yRad);
On 2015/06/05 21:00:59, abarth wrote:
> I was expecting this to be like Rect.dart, which is to say a Dart-native
object
> that coverts into an SkRRect

I think this class is complicated and rarely used enough that we don't need to
have a Dart-native version

https://codereview.chromium.org/1161813005/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/checkbox.dart (right):

https://codereview.chromium.org/1161813005/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/checkbox.dart:40: paint.strokeWidth = 2.0;
On 2015/06/05 21:00:59, abarth wrote:
> Why not use the .. operator to set these values?

Done.

[abarth-chromium, 2015-06-05 21:51:17]

LGTM

[jackson, 2015-06-05 21:51:43]

Committed patchset #3 (id:40001) manually as
32fe72ec0ca7d3bc948a448d5a478c825907cbc3 (presubmit successful).