sky/engine/core/painting/RRect.idl - Issue 1161813005: Implement a simple checkbox in Sky’s fn2 components library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/painting/RRect.idl

Issue 1161813005: Implement a simple checkbox in Sky’s fn2 components library (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Constructor(Color color, TransferMode transferMode),	6 Constructor(),

7 ] interface ColorFilter {	7 ] interface RRect {

	8 void setRectXY(Rect rect, float xRad, float yRad);
	abarth-chromium 2015/06/05 21:00:59 I was expecting this to be like Rect.dart, which i I was expecting this to be like Rect.dart, which is to say a Dart-native object that coverts into an SkRRect jackson 2015/06/05 21:14:11 I think this class is complicated and rarely used Show quoted text On 2015/06/05 21:00:59, abarth wrote: > I was expecting this to be like Rect.dart, which is to say a Dart-native object > that coverts into an SkRRect I think this class is complicated and rarely used enough that we don't need to have a Dart-native version
8 };	9 };

OLD	NEW