Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1161553008: ARM64: Work around Clang's inline assembly limitations. (Closed)

Created:
5 years, 7 months ago by jbramley
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, chh_google.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: Work around Clang's inline assembly limitations. Clang bug: https://llvm.org/bugs/show_bug.cgi?id=23575 This is the simplest workaround; just don't use the "J" constraint for Clang. At worst, an extra `mov` will be generated to synthesize negative values in a register. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/base/atomicops_internals_arm64_gcc.h View 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jbramley
I realise that you may prefer to wait for a Clang fix for this issue. ...
5 years, 7 months ago (2015-05-26 16:33:12 UTC) #2
Benedikt Meurer
I'd prefer a clang fix. But in general the atomicops should be in sync with ...
5 years, 7 months ago (2015-05-26 17:42:15 UTC) #3
jbramley
5 years, 7 months ago (2015-05-28 06:18:10 UTC) #4
Message was sent while issue was closed.
On 2015/05/26 17:42:15, Benedikt Meurer wrote:
> I'd prefer a clang fix. But in general the atomicops should be in sync with
> Chromium base. Did you submit a CL for Chromium base as well?

As discussed, let's wait for an updated Clang.

Powered by Google App Engine
This is Rietveld 408576698