IDL compiler: [NamedConstructor] (basic)

IDL compiler: [NamedConstructor] (basic)

Initial CL; will follow up with arguments, extended attributes, etc.

Perl parser handling of named constructors is hacky (included in
constructors, but treated differently by code generator), so added
FIXMEs to clean this up post-Perl.

Also:
* minor whitespace cleanup in Perl,
* remove unnecessary V8Document.h header, and
* minor refactoring of Python.

Docs:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-NamedConstructor-i-

BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163950

[haraken, 2013-12-16 08:56:18]

LGTM.

> Perl parser handling of named constructors is hacky (included in 
> constructors, but treated differently by code generator), so added 
> FIXMEs to clean this up post-Perl. 

Would it be hard to fix the Perl side now? If it's hard, it's ok to leave the
FIXMEs as is at this point.

https://codereview.chromium.org/116153002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_interface.py (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_interface.py:122:
includes.add('V8Document.h')

Is this needed?

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:153:
result->SetClassName(v8::String::NewFromUtf8(isolate, "{{cpp_class}}",
v8::String::kInternalizedString));

v8::String::NewFromUtf8 => v8Symbol (in V8Binding.h)

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface_base.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface_base.cpp:122:
{{generate_constructor(constructor)}}

Looks like we don't use "generate_" in other places.

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:339:
throwTypeError(ExceptionMessages::failedToConstruct("{{constructor.name}}",
"Please use the 'new' operator, this DOM object constructor cannot be called as
a function."), info.GetIsolate());

Use throw_type_error.

[Nils Barth (inactive), 2013-12-16 09:29:45]

Thanks!

Replies below; to overall question:
> Would it be hard to fix the Perl side now?

Yes, the Perl handling of Constructors (inc. Custom and Named)
is really messy, and the assumptions are in the parser and
in the code generator.
It's a very easy fix post-Perl, but an involved fix now,
hence more efficient later.

https://codereview.chromium.org/116153002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_interface.py (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_interface.py:122:
includes.add('V8Document.h')
On 2013/12/16 08:56:18, haraken wrote:
> Is this needed?

Nope, removed!
It was added for the line:
Document* document = currentDocument();
...but we now always include Document.h, so this isn't needed.

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:153:
result->SetClassName(v8::String::NewFromUtf8(isolate, "{{cpp_class}}",
v8::String::kInternalizedString));
On 2013/12/16 08:56:18, haraken wrote:
> v8::String::NewFromUtf8 => v8Symbol (in V8Binding.h)

There are 13 cases; will fix in followup.

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface_base.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface_base.cpp:122:
{{generate_constructor(constructor)}}
On 2013/12/16 08:56:18, haraken wrote:
> Looks like we don't use "generate_" in other places.

We only use "generate_" to avoid collision with loop variables:
|constructor| = the actual constructor (data structure)
|generate_constructor| = Jinja macro
Ditto for |method| and |argument|.

For non-loop variables, we omit "generate_".
(Same convention in the Python code.)

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/me...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/116153002/diff/1/Source/bindings/templates/me...
Source/bindings/templates/methods.cpp:339:
throwTypeError(ExceptionMessages::failedToConstruct("{{constructor.name}}",
"Please use the 'new' operator, this DOM object constructor cannot be called as
a function."), info.GetIsolate());
On 2013/12/16 08:56:18, haraken wrote:
> 
> Use throw_type_error.

This one case is easier to do literally, because otherwise we'd need
to pass the name around and it would make all other calls longer
(or add *another* level of abstraction (>.<)).
Named constructors are rare and simple, so I'd rather not make the rest of
the code complicated for this case.

[commit-bot: I haz the power, 2013-12-16 09:30:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/116153002/20001

[commit-bot: I haz the power, 2013-12-16 10:36:24]

Change committed as 163950