Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 116153002: IDL compiler: [NamedConstructor] (basic) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/idl_definitions_builder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 9bb654cf472c912adaf6e8d9b1ccb7ad981e7e7b..a0a5565bfee9821123c4808b9a22969be0671c31 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -3072,7 +3072,6 @@ END
$code .= $maybeObserveFeature if $maybeObserveFeature;
$code .= $maybeDeprecateFeature if $maybeDeprecateFeature;
$code .= GenerateConstructorHeader($function->extendedAttributes->{"NamedConstructor"});
- AddToImplIncludes("V8Document.h");
$code .= <<END;
Document* document = currentDocument();
ASSERT(document);
@@ -3112,7 +3111,6 @@ END
}
my $argumentString = join(", ", @beforeArgumentList, @argumentList, @afterArgumentList);
- $code .= "\n";
$code .= " RefPtr<${implClassName}> impl = ${implClassName}::createForJSConstructor(${argumentString});\n";
$code .= " v8::Handle<v8::Object> wrapper = info.Holder();\n";
@@ -3140,7 +3138,7 @@ v8::Handle<v8::FunctionTemplate> ${v8ClassName}Constructor::domTemplate(v8::Isol
if (!result.IsEmpty())
return result;
- TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink\", \"BuildDOMTemplate");
+ TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate");
v8::EscapableHandleScope scope(isolate);
result = v8::FunctionTemplate::New(isolate, ${v8ClassName}ConstructorCallback);
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/idl_definitions_builder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698