IDL compiler: [NamedConstructor] (basic)

Source/bindings/scripts/unstable/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 76 matching lines @@
     # [SpecialWrapFor]
     if 'SpecialWrapFor' in extended_attributes:
         special_wrap_for = extended_attributes['SpecialWrapFor'].split('|')
     else:
         special_wrap_for = []
     for special_wrap_interface in special_wrap_for:
         v8_types.add_includes_for_type(special_wrap_interface)
 
     # Constructors
     constructors = [generate_constructor(interface, constructor)
-                    for constructor in interface.constructors]
+                    for constructor in interface.constructors
+                    # FIXME: shouldn't put named constructors with constructors
+                    # (currently needed for Perl compatibility)
+                    # Handle named constructors separately
+                    if constructor.name == 'Constructor']
     generate_constructor_overloads(constructors)
-    if constructors:
-        includes.add('bindings/v8/V8ObjectConstructor.h')
 
     # [CustomConstructor]
     has_custom_constructor = 'CustomConstructor' in extended_attributes
-    if has_custom_constructor:
-        includes.add('bindings/v8/V8ObjectConstructor.h')
 
     # [EventConstructor]
     has_event_constructor = 'EventConstructor' in extended_attributes
     any_type_attributes = [attribute for attribute in interface.attributes
                            if attribute.idl_type == 'any']
     if has_event_constructor:
-        includes.update(['bindings/v8/Dictionary.h',
-                         'bindings/v8/V8ObjectConstructor.h'])
+        includes.add('bindings/v8/Dictionary.h')
         if any_type_attributes:
             includes.add('bindings/v8/SerializedScriptValue.h')
 
+    # [NamedConstructor]
+    if 'NamedConstructor' in extended_attributes:
+        # FIXME: parser should return named constructor separately;
+        # included in constructors (and only name stored in extended attribute)
+        # for Perl compatibility
+        named_constructor = {'name': extended_attributes['NamedConstructor']}
+        includes.add('V8Document.h')

[haraken, 2013/12/16 08:56:18]

Is this needed?

[Nils Barth (inactive), 2013/12/16 09:29:45]

Nope, removed!
It was added for the line:
Document* document = currentDocument();
...but we now always include Document.h, so this isn't needed.

+    else:
+        named_constructor = None
+
+    if (constructors or has_custom_constructor or has_event_constructor or
+        named_constructor):
+        includes.add('bindings/v8/V8ObjectConstructor.h')
+
     template_contents = {
         'any_type_attributes': any_type_attributes,
         'conditional_string': conditional_string(interface),  # [Conditional]
         'constructors': constructors,
         'cpp_class': cpp_name(interface),
         'generate_visit_dom_wrapper_function': generate_visit_dom_wrapper_function,
         'has_custom_constructor': has_custom_constructor,
         'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'),  # [Custom=LegacyCallAsFunction]
         'has_custom_to_v8': has_extended_attribute_value(interface, 'Custom', 'ToV8'),  # [Custom=ToV8]
         'has_custom_wrap': has_extended_attribute_value(interface, 'Custom', 'Wrap'),  # [Custom=Wrap]
         'has_event_constructor': has_event_constructor,
         'has_visit_dom_wrapper': (
             # [Custom=Wrap], [GenerateVisitDOMWrapper]
             has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapper') or
             'GenerateVisitDOMWrapper' in extended_attributes),
         'header_includes': header_includes,
         'interface_length': interface_length(interface, constructors),
         'interface_name': interface.name,
         'is_active_dom_object': 'ActiveDOMObject' in extended_attributes,  # [ActiveDOMObject]
         'is_check_security': is_check_security,
         'is_constructor_call_with_document': has_extended_attribute_value(
             interface, 'ConstructorCallWith', 'Document'),  # [ConstructorCallWith=Document]
         'is_constructor_call_with_execution_context': has_extended_attribute_value(
             interface, 'ConstructorCallWith', 'ExecutionContext'),  # [ConstructorCallWith=ExeuctionContext]
         'is_constructor_raises_exception': extended_attributes.get('RaisesException') == 'Constructor',  # [RaisesException=Constructor]
         'is_dependent_lifetime': 'DependentLifetime' in extended_attributes,  # [DependentLifetime]
         'measure_as': v8_utilities.measure_as(interface),  # [MeasureAs]
+        'named_constructor': named_constructor,
         'parent_interface': parent_interface,
         'runtime_enabled_function': runtime_enabled_function_name(interface),  # [RuntimeEnabled]
         'special_wrap_for': special_wrap_for,
         'v8_class': v8_utilities.v8_class_name(interface),
     }
 
     template_contents.update({
         'constants': [generate_constant(constant) for constant in interface.constants],
         'do_not_check_constants': 'DoNotCheckConstants' in extended_attributes,
     })
@@ skipping 220 matching lines @@
 
 
 def interface_length(interface, constructors):
     # Docs: http://heycam.github.io/webidl/#es-interface-call
     if 'EventConstructor' in interface.extended_attributes:
         return 1
     if not constructors:
         return 0
     return min(constructor['number_of_required_arguments']
                for constructor in constructors)