Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 11615020: Clean up cc and webkit/compositor_bindings include path shenanigans (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
Reviewers:
piman, enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Clean up cc and webkit/compositor_bindings include path shenanigans This removes various include issues in cc/ and webkit/compositor_bindings/ to normalize this code to chromium standards and make webkit/compositor_bindings/ more easily usable. Changes include: 1.) Removing dead stub / test headers and include paths 2.) Removing complex rules designed to make the incantation '#include <public/WebBlah.h>' work since all chromium code can do '#include "third_party/WebKit/Source/Platform/chromium/public/WebBlah.h"' 3.) Expand out WebKit API includes and sort correctly BUG=144577 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173799

Patch Set 1 #

Patch Set 2 : typo in cc.gyp #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -235 lines) Patch
M cc/DEPS View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M cc/animation_curve.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/cc.gyp View 1 2 2 chunks +17 lines, -10 lines 0 comments Download
D cc/cc.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
M cc/damage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/damage_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/geometry_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/gl_renderer.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M cc/keyframed_animation_curve.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/keyframed_animation_curve_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/layer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layer_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/layer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/platform_color.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/program_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/rate_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_pass.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/render_pass_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/render_surface_filters.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_surface_filters_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resource_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resource_update_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/scrollbar_geometry_fixed_thumb.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/scrollbar_geometry_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_impl_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/shader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/software_renderer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_web_graphics_context_3d.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_web_scrollbar_theme_geometry.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/geometry_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_copier.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings_tests.gyp View 1 2 2 chunks +1 line, -7 lines 0 comments Download
D webkit/compositor_bindings/stubs/public/WebTransformationMatrix.h View 1 chunk +0 lines, -15 lines 0 comments Download
D webkit/compositor_bindings/test/fake_web_scrollbar_theme_geometry.h View 1 chunk +0 lines, -48 lines 0 comments Download
M webkit/compositor_bindings/test/web_layer_tree_view_test_common.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_unittest.cc View 1 chunk +17 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
Mundane cleanup, but without this using the webkit/compositor_bindings/** headers from places outside of webkit/ is ...
8 years ago (2012-12-18 08:02:02 UTC) #1
piman
lgtm
8 years ago (2012-12-18 16:23:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11615020/3001
8 years ago (2012-12-18 18:01:15 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/DEPS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-12-18 18:01:33 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-18 18:21:41 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698