Issue 1161053002: Revert of gin: Use V8 Maybe APIs

Issue 1161053002: Revert of gin: Use V8 Maybe APIs (Closed)

Created:
5 years, 6 months ago by bashi

Modified:
5 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of gin: Use V8 Maybe APIs (patchset #7 id:160001 of https://codereview.chromium.org/1106393002/) Reason for revert: Broke layout tests Original issue's description: > gin: Use V8 Maybe APIs > > TEST=gin_unittests > BUG=479439 > > Committed: https://crrev.com/7a6acf6c7d45e24f07781c69249d90967013bbe4 > Cr-Commit-Position: refs/heads/master@{#331923} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479439 Committed: https://crrev.com/b76f78b6c8bef611e22f45bf0798c46b53379db7 Cr-Commit-Position: refs/heads/master@{#331930}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -205 lines)			Patch
M	gin/arguments.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	gin/converter.h	View	7 chunks	+5 lines, -72 lines	0 comments	Download
M	gin/converter.cc	View	9 chunks	+16 lines, -31 lines	0 comments	Download
M	gin/converter_unittest.cc	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	gin/dictionary.h	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	gin/interceptor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/console.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/module_registry.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gin/modules/module_registry.cc	View	6 chunks	+15 lines, -20 lines	0 comments	Download
M	gin/object_template_builder.cc	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	gin/shell/gin_main.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	gin/shell_runner.cc	View	3 chunks	+10 lines, -15 lines	0 comments	Download
M	gin/test/file.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	gin/try_catch.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gin/try_catch.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	gin/wrappable.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gin/wrappable_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161053002/1

5 years, 6 months ago (2015-05-29 06:53:28 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 06:55:02 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b76f78b6c8bef611e22f45bf0798c46b53379db7
Cr-Commit-Position: refs/heads/master@{#331930}