Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/try_catch.h

Issue 1161053002: Revert of gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/test/file.cc ('k') | gin/try_catch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/try_catch.h
diff --git a/gin/try_catch.h b/gin/try_catch.h
index 84b2ae1646560eb41bf221f78b34e7d3ae64d68f..633b909234139c3040333732b9166b70f4e21b97 100644
--- a/gin/try_catch.h
+++ b/gin/try_catch.h
@@ -16,14 +16,13 @@
// TryCatch is a convenient wrapper around v8::TryCatch.
class GIN_EXPORT TryCatch {
public:
- explicit TryCatch(v8::Isolate* isolate);
+ TryCatch();
~TryCatch();
bool HasCaught();
std::string GetStackTrace();
private:
- v8::Isolate* isolate_;
v8::TryCatch try_catch_;
DISALLOW_COPY_AND_ASSIGN(TryCatch);
« no previous file with comments | « gin/test/file.cc ('k') | gin/try_catch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698