Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: gin/modules/module_registry.h

Issue 1161053002: Revert of gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/console.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index b67387b2ac5815811e4eb53a6e518dd2e65fe3f2..c53155a44a4c78f717ac67ce7f79d218e7161ae5 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -47,7 +47,7 @@
// Installs the necessary functions needed for modules.
// WARNING: this may execute script in the page.
- static bool InstallGlobals(v8::Isolate* isolate, v8::Local<v8::Object> obj);
+ static void InstallGlobals(v8::Isolate* isolate, v8::Local<v8::Object> obj);
void AddObserver(ModuleRegistryObserver* observer);
void RemoveObserver(ModuleRegistryObserver* observer);
@@ -81,8 +81,8 @@
explicit ModuleRegistry(v8::Isolate* isolate);
- bool Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
- bool RegisterModule(v8::Isolate* isolate,
+ void Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
+ void RegisterModule(v8::Isolate* isolate,
const std::string& id,
v8::Local<v8::Value> module);
« no previous file with comments | « gin/modules/console.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698