Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 1161023008: Suggest to fill password change forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index ea8944a26a098cfda0842c0c72e8096fd047d984..3bc6763ed01317b249609274c4cb0109d28e0b56 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -858,7 +858,9 @@ bool PasswordAutofillAgent::ShowSuggestions(
// is no username or the corresponding username element is not editable since
// it is only in that case that the username element does not have a
// suggestions popup.
- if (element.isPasswordField() && username_is_available)
+ if (element.isPasswordField() &&
+ !password_info->fill_data.is_password_change_form &&
Garrett Casto 2015/06/05 21:22:30 Is this because we don't trust that |username_elem
dvadym 2015/06/09 16:40:08 Yeah, we will not trust username element and show
+ username_is_available)
return true;
// Chrome should never show more than one account for a password element since

Powered by Google App Engine
This is Rietveld 408576698