components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 1161023008: Suggest to fill password change forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1161023008: Suggest to fill password change forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/common/password_form_fill_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index e27e482ac4b46aad2da8990eb99fa7e163402eda..ae8b6fc50d84e7cea208f4ef826ab439c3d32e82 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -143,7 +143,8 @@ bool LocateSpecificPasswords(std::vector<WebInputElement> passwords,

*current_password = passwords[0];

break;

case 2:

- if (passwords[0].value() == passwords[1].value()) {

+ if (!passwords[0].value().isEmpty() &&

+ passwords[0].value() == passwords[1].value()) {

Garrett Casto 2015/06/05 21:22:30 You probably want to leave a comment here about wh

dvadym 2015/06/09 16:40:08 Done.

// Two identical passwords: assume we are seeing a new password with a

// confirmation. This can be either a sign-up form or a password change

// form that does not ask for the old password.