Suggest to fill password change forms

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 840 matching lines @@
   if (!IsElementAutocompletable(element) ||
       !IsElementAutocompletable(password_info->password_field))
     return true;
 
   bool username_is_available =
       !username_element->isNull() && IsElementEditable(*username_element);
   // If the element is a password field, a popup should only be shown if there
   // is no username or the corresponding username element is not editable since
   // it is only in that case that the username element does not have a
   // suggestions popup.
-  if (element.isPasswordField() && username_is_available)
+  if (element.isPasswordField() &&
+      !password_info->fill_data.is_password_change_form &&

[Garrett Casto, 2015/06/05 21:22:30]

Is this because we don't trust that |username_element| is correct for change
password forms? I seem to remember this being a problem somewhere, maybe
twitter? Given the other changes this will make it so that a lot of signup forms
will show a saved password when you click on them, though that probably isn't a
huge deal.

[dvadym, 2015/06/09 16:40:08]

Yeah, we will not trust username element and show suggestions for both username
(if present) and password fields. The Facebook password change form has
additional invisible field, that we can't distinguish from username.

+      username_is_available)
     return true;
 
   // Chrome should never show more than one account for a password element since
   // this implies that the username element cannot be modified. Thus even if
   // |show_all| is true, check if the element in question is a password element
   // for the call to ShowSuggestionPopup.
   return ShowSuggestionPopup(
       password_info->fill_data,
       username_element->isNull() ? element : *username_element,
       show_all && !element.isPasswordField(), element.isPasswordField());
@@ skipping 600 matching lines @@
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::DidStopLoading() {
   agent_->DidStopLoading();
 }
 
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
     DidStartProvisionalLoad(blink::WebLocalFrame* navigated_frame) {
   agent_->LegacyDidStartProvisionalLoad(navigated_frame);
 }
 
 }  // namespace autofill