Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1160973006: MIPS: Improve --rpath and --dynamic-linker handling in gyp. (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Improve --rpath and --dynamic-linker handling in gyp. BUG= Committed: https://crrev.com/403799183a20641922980f20d76cda8f79ff7f71 Cr-Commit-Position: refs/heads/master@{#28842}

Patch Set 1 #

Patch Set 2 : Rebased and target_conditions added. #

Total comments: 2

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M build/toolchain.gypi View 1 2 4 chunks +24 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
balazs.kilvady
Seems to work fine at cross-compiling for all the supported mips archs. And simulator builds ...
5 years, 6 months ago (2015-06-03 13:03:51 UTC) #2
balazs.kilvady
I rebased the patch and added the target_conditions check so the --rpath and --dynamic-linker flags ...
5 years, 6 months ago (2015-06-04 17:14:20 UTC) #3
dusmil.imgtec
Lgtm, need approval from Google team.
5 years, 6 months ago (2015-06-05 15:42:20 UTC) #4
dusmil.imgtec
5 years, 6 months ago (2015-06-05 15:42:49 UTC) #6
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi#newcode341 build/toolchain.gypi:341: ['v8_target_arch==target_arch and (v8_target_arch=="mips" or \ nit: ...
5 years, 6 months ago (2015-06-05 15:57:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160973006/40001
5 years, 6 months ago (2015-06-08 13:59:04 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-08 14:25:56 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 14:26:05 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/403799183a20641922980f20d76cda8f79ff7f71
Cr-Commit-Position: refs/heads/master@{#28842}

Powered by Google App Engine
This is Rietveld 408576698