Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2043743005: MIPS: Fix 'Fix Turbofan: Modify WASM linkage to store floats using only 4 bytes.' (Closed)

Created:
4 years, 6 months ago by balazs.kilvady
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Fix Turbofan: Modify WASM linkage to store floats using only 4 bytes.' Port b9ded4ce9cda2053d084e043e8a30a90ae3e801d BUG= TEST=cctest/test-run-native-calls/Float32Select_stack_params_return_reg, cctest/test-run-native-calls/MixedParams_2, cctest/test-run-native-calls/MixedParams_3 Committed: https://crrev.com/bf6ae338451f05853f890f649a1e097a39f29150 Cr-Commit-Position: refs/heads/master@{#36833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +7 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 6 months ago (2016-06-08 14:57:48 UTC) #2
bbudge
lgtm
4 years, 6 months ago (2016-06-08 15:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043743005/1
4 years, 6 months ago (2016-06-08 15:29:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 15:54:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:57:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf6ae338451f05853f890f649a1e097a39f29150
Cr-Commit-Position: refs/heads/master@{#36833}

Powered by Google App Engine
This is Rietveld 408576698