Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1476473002: Add -Wno-sign-compare flag to gcc builds. (Closed)

Created:
5 years ago by balazs.kilvady
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add -Wno-sign-compare flag to gcc builds. Fix gcc 4.9.2 signed-compare warnings/errors. BUG= Committed: https://crrev.com/8e54a667b2c812f8a0f2f506af6c644a952d8569 Cr-Commit-Position: refs/heads/master@{#32367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
balazs.kilvady
With gcc 4.8 the compilation goes fine with and without this CL, after gcc 4.9.2 ...
5 years ago (2015-11-26 17:11:31 UTC) #3
jbramley
On 2015/11/26 17:11:31, balazs.kilvady wrote: > With gcc 4.8 the compilation goes fine with and ...
5 years ago (2015-11-26 17:16:46 UTC) #4
Jakob Kummerow
LGTM (if ARM is fine with this).
5 years ago (2015-11-26 17:27:19 UTC) #5
paul.l...
lgtm. +Andy, fyi. Please re-run the failing trybots, they appear unrelated to me.
5 years ago (2015-11-27 03:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476473002/1
5 years ago (2015-11-27 10:59:56 UTC) #9
Rodolph.Perfetta_arm.com
I am out of office until the 1st of December 2015, I will reply to ...
5 years ago (2015-11-27 11:00:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 11:42:49 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-27 11:43:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e54a667b2c812f8a0f2f506af6c644a952d8569
Cr-Commit-Position: refs/heads/master@{#32367}

Powered by Google App Engine
This is Rietveld 408576698