Issue 11607016: Simplify implementation of assignment-to-const checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11607016: Simplify implementation of assignment-to-const checks (Closed)

Created:
8 years ago by rossberg

Modified:
8 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplify implementation of assignment-to-const checks. Also, add test that assignment to function name is a syntax error with harmony scoping. Does not fix issue 2243 directly, but with ES6, the required behaviour will change to what is implemented already anyway. R=yangguo@chromium.org BUG=v8:2243 Committed: http://code.google.com/p/v8/source/detail?r=13234

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -59 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/scopes.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/scopes.cc	View		4 chunks	+16 lines, -43 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-2243.js	View		1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comment. https://codereview.chromium.org/11607016/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/11607016/diff/1/src/ia32/full-codegen-ia32.cc#newcode1980 src/ia32/full-codegen-ia32.cc:1980: // Invalid left-hand sides are rewritten ...

8 years ago (2012-12-18 10:50:10 UTC) #2

rossberg

8 years ago (2012-12-18 11:58:38 UTC) #3

https://codereview.chromium.org/11607016/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/11607016/diff/1/src/ia32/full-codegen-ia32.cc...
src/ia32/full-codegen-ia32.cc:1980: // Invalid left-hand sides are rewritten by
the parser to have a 'throw
On 2012/12/18 10:50:10, Yang wrote:
> Want to "port" that comment to other platforms?

Done.

Expand Messages | Collapse Messages