src/parser.cc - Issue 11607016: Simplify implementation of assignment-to-const checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 11607016: Simplify implementation of assignment-to-const checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 94d2f9e6a09586ce3713e0d4dffd6e7e69c9c768..ab82ef70892c27e41093a4d4226b918a60d1736f 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -3006,6 +3006,7 @@ Expression* Parser::ParseAssignmentExpression(bool accept_IN, bool* ok) {

// side expression. We could report this as a syntax error here but

// for compatibility with JSC we choose to report the error at

// runtime.

+ // TODO(ES5): Should change parsing for spec conformance.

if (expression == NULL || !expression->IsValidLeftHandSide()) {

Handle<String> type =

isolate()->factory()->invalid_lhs_in_assignment_symbol();

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/scopes.h » ('j') | no next file with comments »