Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 11607016: Simplify implementation of assignment-to-const checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/scopes.cc ('k') | test/mjsunit/regress/regress-2243.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1947 matching lines...) Expand 10 before | Expand all | Expand 10 after
1958 BinaryOpStub stub(op, mode); 1958 BinaryOpStub stub(op, mode);
1959 JumpPatchSite patch_site(masm_); // unbound, signals no inlined smi code. 1959 JumpPatchSite patch_site(masm_); // unbound, signals no inlined smi code.
1960 CallIC(stub.GetCode(), RelocInfo::CODE_TARGET, 1960 CallIC(stub.GetCode(), RelocInfo::CODE_TARGET,
1961 expr->BinaryOperationFeedbackId()); 1961 expr->BinaryOperationFeedbackId());
1962 patch_site.EmitPatchInfo(); 1962 patch_site.EmitPatchInfo();
1963 context()->Plug(rax); 1963 context()->Plug(rax);
1964 } 1964 }
1965 1965
1966 1966
1967 void FullCodeGenerator::EmitAssignment(Expression* expr) { 1967 void FullCodeGenerator::EmitAssignment(Expression* expr) {
1968 // Invalid left-hand sides are rewritten to have a 'throw 1968 // Invalid left-hand sides are rewritten by the parser to have a 'throw
1969 // ReferenceError' on the left-hand side. 1969 // ReferenceError' on the left-hand side.
1970 if (!expr->IsValidLeftHandSide()) { 1970 if (!expr->IsValidLeftHandSide()) {
1971 VisitForEffect(expr); 1971 VisitForEffect(expr);
1972 return; 1972 return;
1973 } 1973 }
1974 1974
1975 // Left-hand side can only be a property, a global or a (parameter or local) 1975 // Left-hand side can only be a property, a global or a (parameter or local)
1976 // slot. 1976 // slot.
1977 enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY }; 1977 enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY };
1978 LhsKind assign_type = VARIABLE; 1978 LhsKind assign_type = VARIABLE;
(...skipping 2539 matching lines...) Expand 10 before | Expand all | Expand 10 after
4518 *context_length = 0; 4518 *context_length = 0;
4519 return previous_; 4519 return previous_;
4520 } 4520 }
4521 4521
4522 4522
4523 #undef __ 4523 #undef __
4524 4524
4525 } } // namespace v8::internal 4525 } } // namespace v8::internal
4526 4526
4527 #endif // V8_TARGET_ARCH_X64 4527 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/scopes.cc ('k') | test/mjsunit/regress/regress-2243.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698