Issue 11602013: Redesign scope API, separate declarative and object scopes.

Issue 11602013: Redesign scope API, separate declarative and object scopes. (Closed)

Created:
7 years, 12 months ago by Peter Rybin

Modified:
7 years, 11 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Redesign scope API, separate declarative and object scopes. Committed: http://code.google.com/p/chromedevtools/source/detail?r=1119

Patch Set 4 : patching other backends #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -241 lines)			Patch
M	plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java	View	1	3 chunks	+33 lines, -18 lines	0 comments	Download
M	plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java	View		2 chunks	+4 lines, -12 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2 3	3 chunks	+35 lines, -28 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2 3	3 chunks	+38 lines, -25 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.wk118685/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2 3	2 chunks	+34 lines, -25 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.wk120709/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2 3	2 chunks	+34 lines, -25 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/JsScope.java	View	1	2 chunks	+29 lines, -10 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java	View	1 2	8 chunks	+47 lines, -61 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm with comments https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java File plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java (right): https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode598 plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:598: @Override public ObjectBased asObjectBased() { blank ...

7 years, 12 months ago (2012-12-27 08:02:16 UTC) #2

Peter Rybin

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java File plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java (right): https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode598 plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:598: @Override public ObjectBased asObjectBased() { On 2012/12/27 08:02:16, apavlov ...

7 years, 11 months ago (2013-01-09 15:30:31 UTC) #3

Expand Messages | Collapse Messages