Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java

Issue 11602013: Redesign scope API, separate declarative and object scopes. (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: patching other backends Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java
diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java
index eb97d7f1d5a5e92b68094809cb55cc069c58d6f4..9ad5f412cfe101867953613d9cee87c8d1e2334b 100644
--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java
+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java
@@ -90,43 +90,6 @@ public abstract class ValueBase extends DebugElementImpl.WithEvaluate implements
}
/**
- * Wraps {@link JsScope} as a Value. Scope's variables are inner variables of the Value.
- */
- static class ScopeValue extends ValueBase.ValueWithLazyVariables {
- private final JsScope jsScope;
- private final ExpressionTracker.Node expressionNode;
-
- ScopeValue(EvaluateContext evaluateContext, JsScope jsScope,
- ExpressionTracker.Node expressionNode) {
- super(evaluateContext);
- this.jsScope = jsScope;
- this.expressionNode = expressionNode;
- }
- @Override public String getReferenceTypeName() throws DebugException {
- return "#Scope";
- }
- @Override public String getValueString() {
- return null;
- }
- @Override public boolean isAllocated() throws DebugException {
- return true;
- }
- @Override public boolean hasVariables() throws DebugException {
- return true;
- }
- @Override public Value asRealValue() {
- return null;
- }
-
- @Override
- protected IVariable[] calculateVariables() {
- return StackFrame.wrapVariables(getEvaluateContext(), jsScope.getVariables(),
- Collections.<String>emptySet(), Collections.<JsVariable>emptyList(), null,
- expressionNode);
- }
- }
-
- /**
* Wraps string error message as a Value. It may have optional inner variable 'exception' that
* wraps exception value.
*/

Powered by Google App Engine
This is Rietveld 408576698