Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 1160123004: Oilpan: safely finalize DOMTimers. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: safely finalize DOMTimers. DOMTimer objects need to be eagerly finalized so as to prevent timer events from firing at a DOMTimer that's about to be lazily swept. If allowed, that might result in accessing an already finalized m_action member. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196504

Patch Set 1 #

Patch Set 2 : rename dispose() as disposeTimer() #

Patch Set 3 : Fix grammatical error in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/frame/DOMTimer.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/frame/DOMTimer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMTimerCoordinator.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-04 11:30:35 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-04 12:47:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160123004/40001
5 years, 6 months ago (2015-06-04 12:52:24 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 14:04:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196504

Powered by Google App Engine
This is Rietveld 408576698