Issue 1160123004: Oilpan: safely finalize DOMTimers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160123004: Oilpan: safely finalize DOMTimers. (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: safely finalize DOMTimers. DOMTimer objects need to be eagerly finalized so as to prevent timer events from firing at a DOMTimer that's about to be lazily swept. If allowed, that might result in accessing an already finalized m_action member. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196504

Patch Set 1 #

Patch Set 2 : rename dispose() as disposeTimer() #

Patch Set 3 : Fix grammatical error in comment #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
M	Source/core/frame/DOMTimer.h	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	Source/core/frame/DOMTimer.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/DOMTimerCoordinator.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160123004/40001

5 years, 6 months ago (2015-06-04 12:52:24 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-04 14:04:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196504

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages