Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: Source/core/frame/DOMTimer.h

Issue 1160123004: Oilpan: safely finalize DOMTimers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix grammatical error in comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/frame/DOMTimer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 virtual ~DOMTimer(); 50 virtual ~DOMTimer();
51 51
52 // ActiveDOMObject 52 // ActiveDOMObject
53 virtual void stop() override; 53 virtual void stop() override;
54 54
55 // The following are essentially constants. All intervals are in seconds. 55 // The following are essentially constants. All intervals are in seconds.
56 static double hiddenPageAlignmentInterval(); 56 static double hiddenPageAlignmentInterval();
57 static double visiblePageAlignmentInterval(); 57 static double visiblePageAlignmentInterval();
58 58
59 // Eager finalization is needed to promptly stop this Timer object.
60 // Otherwise timer events might fire at an object that's slated for destruct ion
61 // (when lazily swept), but some of its members (m_action) may already have
62 // been finalized & must not be accessed.
63 EAGERLY_FINALIZE();
59 DECLARE_VIRTUAL_TRACE(); 64 DECLARE_VIRTUAL_TRACE();
60 65
61 void dispose(); 66 void disposeTimer();
62 67
63 private: 68 private:
64 friend class DOMTimerCoordinator; // For create(). 69 friend class DOMTimerCoordinator; // For create().
65 70
66 static PassRefPtrWillBeRawPtr<DOMTimer> create(ExecutionContext* context, Pa ssOwnPtrWillBeRawPtr<ScheduledAction> action, int timeout, bool singleShot, int timeoutID) 71 static PassRefPtrWillBeRawPtr<DOMTimer> create(ExecutionContext* context, Pa ssOwnPtrWillBeRawPtr<ScheduledAction> action, int timeout, bool singleShot, int timeoutID)
67 { 72 {
68 return adoptRefWillBeNoop(new DOMTimer(context, action, timeout, singleS hot, timeoutID)); 73 return adoptRefWillBeNoop(new DOMTimer(context, action, timeout, singleS hot, timeoutID));
69 } 74 }
70 75
71 DOMTimer(ExecutionContext*, PassOwnPtrWillBeRawPtr<ScheduledAction>, int int erval, bool singleShot, int timeoutID); 76 DOMTimer(ExecutionContext*, PassOwnPtrWillBeRawPtr<ScheduledAction>, int int erval, bool singleShot, int timeoutID);
72 virtual void fired() override; 77 virtual void fired() override;
73 78
74 // Retuns timer fire time rounded to the next multiple of timer alignment in terval. 79 // Retuns timer fire time rounded to the next multiple of timer alignment in terval.
75 virtual double alignedFireTime(double) const override; 80 virtual double alignedFireTime(double) const override;
76 81
77 int m_timeoutID; 82 int m_timeoutID;
78 int m_nestingLevel; 83 int m_nestingLevel;
79 OwnPtrWillBeMember<ScheduledAction> m_action; 84 OwnPtrWillBeMember<ScheduledAction> m_action;
80 RefPtr<UserGestureToken> m_userGestureToken; 85 RefPtr<UserGestureToken> m_userGestureToken;
81 }; 86 };
82 87
83 } // namespace blink 88 } // namespace blink
84 89
85 #endif // DOMTimer_h 90 #endif // DOMTimer_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/DOMTimer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698