Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: Source/core/frame/DOMTimer.h

Issue 1160123004: Oilpan: safely finalize DOMTimers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix grammatical error in comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/DOMTimer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMTimer.h
diff --git a/Source/core/frame/DOMTimer.h b/Source/core/frame/DOMTimer.h
index ad25afed777f2acae9aa2050cccee20130f9c1c8..508a1841884529871b964b78685b9a1f6be0da7d 100644
--- a/Source/core/frame/DOMTimer.h
+++ b/Source/core/frame/DOMTimer.h
@@ -56,9 +56,14 @@ public:
static double hiddenPageAlignmentInterval();
static double visiblePageAlignmentInterval();
+ // Eager finalization is needed to promptly stop this Timer object.
+ // Otherwise timer events might fire at an object that's slated for destruction
+ // (when lazily swept), but some of its members (m_action) may already have
+ // been finalized & must not be accessed.
+ EAGERLY_FINALIZE();
DECLARE_VIRTUAL_TRACE();
- void dispose();
+ void disposeTimer();
private:
friend class DOMTimerCoordinator; // For create().
« no previous file with comments | « no previous file | Source/core/frame/DOMTimer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698