First patch for Mips subzero compiler

First patch for Mips subzero compiler

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4167

[reedkotler, 2015-05-27 19:05:21]

reedkotler@gmail.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-05-30 00:47:15]

Also change the BUG line to list the URL.

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def
File src/IceInstMIPS32.def (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def#newco...
src/IceInstMIPS32.def:19: // Mips skelleton in.
skeleton

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def#newco...
src/IceInstMIPS32.def:24: X(Reg_AT,       = Reg_ZERO + 1,   "at",    1, 0, 0, 0,
1, 0)                   \
Fix alignment manually and keep to 80-char lines.

I think clang-format likes to put these \ characters all at column 80, so we
should probably do the same manually in the .def files.

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def#newco...
src/IceInstMIPS32.def:60: // TODO(jvoung): List FP registers and know S0 == D0
== Q0, etc.
add kotler to TODO list?

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def#newco...
src/IceInstMIPS32.def:74: #define REGMIPS32_TABLE_BOUNDS                        
                  \
fix \ alignment

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.def#newco...
src/IceInstMIPS32.def:80: // TODO(jvoung): add condition code tables, etc.
add kotler to TODO list?

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceInstMIPS32.h#newcode1
src/IceInstMIPS32.h:1: //===- subzero/src/IceInstMIPS32.h - MIPS32 machine
instructions --*- C++ -*-===//
80-col
Maybe instructions==>instrs ?

https://codereview.chromium.org/1159823004/diff/1/src/IceRegistersMIPS32.h
File src/IceRegistersMIPS32.h (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceRegistersMIPS32.h#ne...
src/IceRegistersMIPS32.h:1: //===- subzero/src/IceRegistersMIPS32.h - Register
information ---*- C++ -*-===//
remove a '-' to maintain 80-col

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLowering.cpp
File src/IceTargetLowering.cpp (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLowering.cpp#n...
src/IceTargetLowering.cpp:28: #include "IceTargetLoweringMIPS32.h"
sort includes

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1: //===-
subzero/src/IceTargetLoweringMIPS32.cpp - MIPS32 lowering ------------===//
80-col

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:45: IntegerRegisters[RegMIPS32::val] = isInt;   
                                 \
80-col.  "make format" should take care of this

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.def (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.def:1: //===-
subzero/src/IceTargetLoweringMIPS32.def - MIPS32 X-macros --*- C++ -*-===//
80-col

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.def:18: // TODO(jvoung): Fill out comparison tables,
etc. for 32/64-bit compares.
add kotler to TODO?

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32.h
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.h:1: //===- subzero/src/IceTargetLoweringMIPS32.h -
MIPS32 lowering ----*- C++ -*-===//
80-col

https://codereview.chromium.org/1159823004/diff/1/src/IceTypes.def
File src/IceTypes.def (right):

https://codereview.chromium.org/1159823004/diff/1/src/IceTypes.def#newcode29
src/IceTypes.def:29: X(Target_MIPS32, "mips32",  false, EM_MIPS,   0)         \
Fix the formatting, manually since "make format" doesn't touch .def files.

https://codereview.chromium.org/1159823004/diff/1/src/assembler_mips32.h
File src/assembler_mips32.h (right):

https://codereview.chromium.org/1159823004/diff/1/src/assembler_mips32.h#newc...
src/assembler_mips32.h:1: //===- subzero/src/assembler_mips.h - Assembler for
MIPS ------*- C++ -*-===//
add an extra '--' to pad // to end of line

[reedkotler, 2015-06-03 02:07:34]

On 2015/06/03 01:45:55, reedkotler wrote:

I've updated the patch to reflect the review comments.

[Jim Stichnoth, 2015-06-03 02:10:44]

Thanks!

BTW, the normal practice is to explicitly respond to each comment (clicking
"Done" is often all that's needed), and those responses are emailed out when you
"Publish+Mail Comments".

https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def
File src/IceTypes.def (right):

https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def#newcode29
src/IceTypes.def:29: X(Target_MIPS32, "mips32",  false, EM_MIPS,   0)           
          \
Formatting is still a bit off - all the columns in the X() lines should line up,
and also the \ column is one char less than the rest of the X() lines in the
file.

[reedkotler, 2015-06-03 03:31:02]

Done

[reedkotler, 2015-06-03 03:32:31]

On 2015/06/03 03:31:02, reedkotler wrote:
> Done

Not sure where I was supposed to click to mark your comment as "done".

[Jim Stichnoth, 2015-06-03 03:42:50]

On 2015/06/03 03:32:31, reedkotler wrote:
> On 2015/06/03 03:31:02, reedkotler wrote:
> > Done
> 
> Not sure where I was supposed to click to mark your comment as "done".

The comment in e.g.
https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def#newcode29
is initially collapsed to 1 line.  Click it and it expands to the full comment,
and at the bottom are "Reply", "Done", and "Ack" buttons.

LGTM.

BTW, before landing, you'll probably have to pull the latest changes, using "git
pull --rebase".  Hopefully there won't be any conflicts...

[reedkotler, 2015-06-03 03:47:43]

On 2015/06/03 03:42:50, stichnot wrote:
> On 2015/06/03 03:32:31, reedkotler wrote:
> > On 2015/06/03 03:31:02, reedkotler wrote:
> > > Done
> > 
> > Not sure where I was supposed to click to mark your comment as "done".
> 
> The comment in e.g.
>
https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def#newcode29
> is initially collapsed to 1 line.  Click it and it expands to the full
comment,
> and at the bottom are "Reply", "Done", and "Ack" buttons.
> 
> LGTM.
> 
> BTW, before landing, you'll probably have to pull the latest changes, using
"git
> pull --rebase".  Hopefully there won't be any conflicts...

I think that I have to put back first the other two patches or else this one
won't compile.

I will look into this tomorrow.

[reedkotler, 2015-06-03 03:49:11]

https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def
File src/IceTypes.def (right):

https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def#newcode29
src/IceTypes.def:29: X(Target_MIPS32, "mips32",  false, EM_MIPS,   0)           
          \
On 2015/06/03 02:10:43, stichnot wrote:
> Formatting is still a bit off - all the columns in the X() lines should line
up,
> and also the \ column is one char less than the rest of the X() lines in the
> file.

Done.

[reed.kotler, 2015-06-08 18:29:13]

On 2015/06/03 03:49:11, reedkotler wrote:
> https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def
> File src/IceTypes.def (right):
> 
>
https://codereview.chromium.org/1159823004/diff/20001/src/IceTypes.def#newcode29
> src/IceTypes.def:29: X(Target_MIPS32, "mips32",  false, EM_MIPS,   0)         
 
>           \
> On 2015/06/03 02:10:43, stichnot wrote:
> > Formatting is still a bit off - all the columns in the X() lines should line
> up,
> > and also the \ column is one char less than the rest of the X() lines in the
> > file.
> 
> Done.

This issue moved to:
https://codereview.chromium.org/1169533003/