Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1159703006: Remove the exceptional cases to support the minimized and fullscreen state (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by joone
Modified:
2 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the exceptional cases to support the minimized/fullscreen state for Desktop Linux ui::SHOW_STATE_MINIMIZED and ui::SHOW_STATE_FULLSCREEN started to be handled in Desktop Linux when using chrome.windows.create API in r329764. So, we can remove the exceptional cases to support the states for Desktop Linux. BUG=459841, 473228 Committed: https://crrev.com/22231ecb82de3ad5ed6f80b81698170bc52f2991 Cr-Commit-Position: refs/heads/master@{#331726}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
joone
This CL was separated from https://codereview.chromium.org/1130033003/ Please take a look at this CL.
2 years, 2 months ago (2015-05-27 21:55:45 UTC) #2
tapted
Thanks for doing this! You should have BUG=459841,473228 since this is related to both. First ...
2 years, 2 months ago (2015-05-27 23:20:47 UTC) #3
not at google - send to devlin
if trent is happy, then lgtm from me.
2 years, 2 months ago (2015-05-27 23:28:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159703006/1
2 years, 2 months ago (2015-05-28 00:01:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 2 months ago (2015-05-28 02:33:51 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22231ecb82de3ad5ed6f80b81698170bc52f2991 Cr-Commit-Position: refs/heads/master@{#331726}
2 years, 2 months ago (2015-05-28 02:34:47 UTC) #9
joone
2 years, 2 months ago (2015-05-28 16:44:53 UTC) #10
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b