Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 7 months ago by joone Modified:
5 years, 7 months ago Reviewers:
Elliot Glaysher, Peter Kasting CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport MINIMIZED, MAXIMIZED, FULLSCREEN state when showing a chrome window.
Some of ui::WindowShowState were not supported in Linux so this CL implemented
SHOW_STATE_MINIMIZED, SHOW_STATE_MAXIMIZED, and SHOW_STATE_FULLSCREEN state.
BUG=473228
Committed: https://crrev.com/3a3f2f572a3a96957a6180056e7cbd30f551200d
Cr-Commit-Position: refs/heads/master@{#329764}
Patch Set 1 #
Total comments: 2
Created: 5 years, 7 months ago
Messages
Total messages: 16 (4 generated)
joone.hur@intel.com changed reviewers: + erg@chromium.org
Please take a look at this patch.
lgtm
The CQ bit was checked by joone.hur@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125383008/1
pkasting@chromium.org changed reviewers: + pkasting@chromium.org
https://codereview.chromium.org/1125383008/diff/1/ui/views/widget/desktop_aur... File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/1125383008/diff/1/ui/views/widget/desktop_aur... ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:382: SetFullscreen(TRUE); Shouldn't this be "true" instead of "TRUE"?
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3a3f2f572a3a96957a6180056e7cbd30f551200d Cr-Commit-Position: refs/heads/master@{#329764}
Message was sent while issue was closed.
https://codereview.chromium.org/1125383008/diff/1/ui/views/widget/desktop_aur... File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/1125383008/diff/1/ui/views/widget/desktop_aur... ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:382: SetFullscreen(TRUE); On 2015/05/14 00:10:13, Peter Kasting wrote: > Shouldn't this be "true" instead of "TRUE"? Yes, it should be true. I'll fix it.
Message was sent while issue was closed.
Please land this change.
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted
Message was sent while issue was closed.
On 2015/05/14 21:38:43, joone wrote: > Please land this change. If a CL has already been landed and the Rietveld issue closed, the best thing to do to land followon modifications is to upload them separately as a new CL on a different issue. I'm going to delete the patch here so future spelunkers will see the one you actually landed on this review.
Message was sent while issue was closed.
On 2015/05/14 21:41:02, Peter Kasting wrote: > I'm going to delete the patch here so future spelunkers will see the one you > actually landed on this review. Hmm, someone beat me to it it seems.
Message was sent while issue was closed.
On 2015/05/14 21:38:43, joone wrote: > Please land this change. https://codereview.chromium.org/1124193005
Message was sent while issue was closed.
On 2015/05/14 21:41:32, Peter Kasting wrote: > On 2015/05/14 21:41:02, Peter Kasting wrote: > > I'm going to delete the patch here so future spelunkers will see the one you > > actually landed on this review. > > Hmm, someone beat me to it it seems. Sorry. I deleted it. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
