Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1159703006: Remove the exceptional cases to support the minimized and fullscreen state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 2224bcfd7e67913dd3840938cad7df5ba147e41e..0e762ea5d1bdbed7f0082942d1f4f6c4cf46f302 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -659,22 +659,12 @@ bool WindowsCreateFunction::RunSync() {
WindowController* controller = new_window->extension_window_controller();
-#if defined(OS_LINUX) || defined(OS_CHROMEOS)
- // On Desktop Linux, window managers may ignore hints until the X11 window is
- // mapped, which happens in the blocking call to Show() above.
- // DesktopWindowTreeHostX11 currently only checks for an attempt to maximize
- // once mapped, but not minimize or fullscreen.
+#if defined(OS_CHROMEOS)
// For ChromeOS, manually Minimize(). Because minimzied window is not
// considered to create new window. See http://crbug.com/473228.
if (create_params.initial_show_state == ui::SHOW_STATE_MINIMIZED)
new_window->window()->Minimize();
#endif
-#if (defined(OS_LINUX) && !defined(OS_CHROMEOS))
- // On Desktop Linux managers don't handle fullscreen state to
- // create window for now.
- if (create_params.initial_show_state == ui::SHOW_STATE_FULLSCREEN)
- controller->SetFullscreenMode(true, extension()->url());
-#endif
if (new_window->profile()->IsOffTheRecord() &&
!GetProfile()->IsOffTheRecord() && !include_incognito()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698