Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1159703005: Revert "Allow arbitrary scale factors." (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Revert "Allow arbitrary scale factors." Reason for revert: crbug.ccom/484400 BUG=143619, 484400 TBR=erg@chromium.org, estade@chromium.org, oshima@chromium.org, stapelberg@google.com > Allow arbitrary scale factors. > > As discussed in https://codereview.chromium.org/1070433002/, this CL > allows arbitrary scale factors, which works because chromium uses the > resource most closely matching the scale factor (e.g. 1x for 1.25x, > but 2x for 1.9x) and scales it. > > BUG=143619, 477716 > > Review URL: https://codereview.chromium.org/1078423002 > > Cr-Commit-Position: refs/heads/master@{#326851} > (cherry picked from commit b3ca230ddd7d1238ee96ed26ea23e369f10dd655) > > device scale factor detection: use gtk-xft-dpi consistently > > Before this CL, we used either gtk-xft-dpi (UI fonts) or the physical DPI of > a more or less random display. This CL consistently uses gtk-xft-dpi which > is the better alternative: users can directly influence it (by changing the > Xft.dpi X resource, or via their gtkrc). > > See also https://github.com/derat/font-config-info for displaying your > current system settings. > > This is a re-do of https://codereview.chromium.org/1070433002/, but with > https://codereview.chromium.org/1084453002/ applied (fixes content_shell). > > BUG=473089, 143619 > > Review URL: https://codereview.chromium.org/1085603002 > > Cr-Commit-Position: refs/heads/master@{#324928} > (cherry picked from commit d459a5c49a02507b9ac77ffbbf33dffeb3bc9c34) > > R=stapelberg@google.com > TBR=erg, estade, oshima > > Review URL: https://codereview.chromium.org/1103383004 > > Cr-Commit-Position: refs/branch-heads/2357@{#246} > Cr-Branched-From: 59d4494849b405682265ed5d3f5164573b9a939b-refs/heads/master@{#323860} Committed: https://chromium.googlesource.com/chromium/src/+/1e83acd552618ab337d286187ed23d84434bd122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M testing/xvfb.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 5 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
5 years, 7 months ago (2015-05-26 20:45:25 UTC) #1
oshima
5 years, 7 months ago (2015-05-26 20:49:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e83acd552618ab337d286187ed23d84434bd122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698