Allow arbitrary scale factors.

Allow arbitrary scale factors.

As discussed in https://codereview.chromium.org/1070433002/, this CL
allows arbitrary scale factors, which works because chromium uses the
resource most closely matching the scale factor (e.g. 1x for 1.25x,
but 2x for 1.9x) and scales it.

BUG=143619
Committed: https://crrev.com/b3ca230ddd7d1238ee96ed26ea23e369f10dd655
Cr-Commit-Position: refs/heads/master@{#326851}

[stapelberg, 2015-04-12 21:01:13]

stapelberg@google.com changed reviewers:
+ oshima@chromium.org

[oshima, 2015-04-15 18:38:14]

lgtm

[stapelberg, 2015-04-16 08:56:06]

The CQ bit was checked by stapelberg@google.com

[commit-bot: I haz the power, 2015-04-16 08:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/1

[commit-bot: I haz the power, 2015-04-16 09:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 09:06:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[stapelberg, 2015-04-17 11:55:07]

stapelberg@google.com changed reviewers:
+ estade@chromium.org

[stapelberg, 2015-04-17 11:55:08]

+estade for OWNERS approval

[Evan Stade, 2015-04-17 18:06:51]

On 2015/04/17 11:55:08, stapelberg wrote:
> +estade for OWNERS approval

rubber stamp lgtm

[stapelberg, 2015-04-20 08:36:44]

The CQ bit was checked by stapelberg@google.com

[commit-bot: I haz the power, 2015-04-20 08:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/1

[commit-bot: I haz the power, 2015-04-20 11:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 11:08:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stapelberg, 2015-04-20 15:21:58]

oshima, I don’t yet understand why the tests fail. Could you take a look and
explain what needs fixing please?

[stapelberg, 2015-04-24 09:38:28]

The CQ bit was checked by stapelberg@google.com

[commit-bot: I haz the power, 2015-04-24 09:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/1

[commit-bot: I haz the power, 2015-04-24 10:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 10:58:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stapelberg, 2015-04-24 11:23:44]

When I run the tests using xvfb as described on
https://www.chromium.org/developers/testing/running-tests#TOC-Linux, they pass.
When I run them without xvfb, they don’t. This is both with and without my
change. Let’s see if I can figure out how the environment looks like that the
trybots use.

[stapelberg, 2015-04-24 12:45:37]

Still not sure why this is not reproducible on my machine:

I’ve re-built with the same flags that the trybot uses:

$ GYP_DEFINES="asan=1 clang=1 component=static_library dcheck_always_on=1
fastbuild=1 lsan=1 target_arch=x64 test_isolation_mode=prepare"
GYP_GENERATORS=ninja ./build/gyp_chromium -D use_goma=1
$ ninja -C out/Debug -j 100 chrome content_shell base_unittests browser_tests
interactive_ui_tests
$ python ./testing/xvfb.py $PWD/out/Release ./out/Release/browser_tests
--gtest_filter=ExtensionApiTest.WindowOpenSized
Additional test environment:                                                    
                                                         
    CHROME_DEVEL_SANDBOX=/usr/local/sbin/chrome-devel-sandbox
    LANG=en_US.UTF-8
Command: ./out/Release/browser_tests
--gtest_filter=ExtensionApiTest.WindowOpenSized

IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = ExtensionApiTest.WindowOpenSized
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExtensionApiTest, where TypeParam = 
[ RUN      ] ExtensionApiTest.WindowOpenSized
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[10640:10640:0424/053328:WARNING:password_store_factory.cc(259)] Using basic
(unencrypted) store for password storage. See
http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information
about password storage options.
[10640:10666:0424/053328:WARNING:data_reduction_proxy_config.cc(308)] SPDY proxy
OFF at startup
[10640:10640:0424/053329:INFO:CONSOLE(0)] "[SUCCESS] openSizedWindow", source:
chrome-extension://pdglcblgmcheidefdfaoohnnpnceilcd/test.html (0)
[13:14:0424/053329:WARNING:channel.cc(549)] Failed to send message to ack remove
remote endpoint (local ID 2147483648, remote ID 2)
[10640:10640:0424/053329:WARNING:pref_notifier_impl.cc(27)] pref observer found
at shutdown plugins.allow_outdated
[10640:10640:0424/053329:WARNING:pref_notifier_impl.cc(27)] pref observer found
at shutdown printing.enabled
[10640:10640:0424/053329:WARNING:pref_notifier_impl.cc(27)] pref observer found
at shutdown plugins.always_authorize
[       OK ] ExtensionApiTest.WindowOpenSized (928 ms)
[----------] 1 test from ExtensionApiTest (928 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (928 ms total)
[  PASSED  ] 1 test.
[1/1] ExtensionApiTest.WindowOpenSized (1044 ms)
SUCCESS: all tests passed.

[stapelberg, 2015-04-24 13:09:53]

The CQ bit was checked by stapelberg@google.com

[stapelberg, 2015-04-24 13:09:54]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1078423002/#ps20001
(title: "Allow arbitrary scale factors.")

[commit-bot: I haz the power, 2015-04-24 13:10:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/20001

[stapelberg, 2015-04-24 14:27:26]

The CQ bit was unchecked by stapelberg@google.com

[stapelberg, 2015-04-24 14:27:30]

The CQ bit was checked by stapelberg@google.com

[commit-bot: I haz the power, 2015-04-24 14:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/20001

[commit-bot: I haz the power, 2015-04-24 15:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 15:06:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stapelberg, 2015-04-24 15:09:54]

The CQ bit was checked by stapelberg@google.com

[commit-bot: I haz the power, 2015-04-24 15:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/20001

[stapelberg, 2015-04-24 15:14:50]

The CQ bit was checked by stapelberg@google.com

[stapelberg, 2015-04-24 15:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1078423002/#ps40001
(title: "Allow arbitrary scale factors.")

[commit-bot: I haz the power, 2015-04-24 15:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/40001

[oshima, 2015-04-24 16:11:19]

Bots may have different gtk-xft-dpi. Can you check the value using try?

You may also want to round it to the 0.1 precision.

On Fri, Apr 24, 2015 at 4:23 AM, <stapelberg@google.com> wrote:

> When I run the tests using xvfb as described on
> https://www.chromium.org/developers/testing/running-tests#TOC-Linux, they
> pass.
> When I run them without xvfb, they don’t. This is both with and without my
> change. Let’s see if I can figure out how the environment looks like that
> the
> trybots use.
>
> https://codereview.chromium.org/1078423002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stapelberg, 2015-04-24 18:24:50]

The CQ bit was checked by stapelberg@google.com

[stapelberg, 2015-04-24 18:24:50]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1078423002/#ps100001
(title: "Allow arbitrary scale factors.")

[commit-bot: I haz the power, 2015-04-24 18:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078423002/100001

[commit-bot: I haz the power, 2015-04-24 19:04:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-24 19:05:20]

Patchset 6 (id:??) landed as
https://crrev.com/b3ca230ddd7d1238ee96ed26ea23e369f10dd655
Cr-Commit-Position: refs/heads/master@{#326851}

[mdempsky, 2015-05-05 00:28:18]

mdempsky@chromium.org changed reviewers:
+ mdempsky@chromium.org

[mdempsky, 2015-05-05 00:28:19]

This makes at least gmail, github, and my Chrome theme look anywhere from bad to
horrible on a 101dpi monitor. crbug.com/484400, crbug.com/484411,
crbug.com/484412

[lushnikov, 2015-06-11 00:56:24]

On 2015/05/05 00:28:19, mdempsky wrote:
> This makes at least gmail, github, and my Chrome theme look anywhere from bad
to
> horrible on a 101dpi monitor. crbug.com/484400, crbug.com/484411,
> crbug.com/484412

This change also makes Chrome DevTools to be blurred under certain conditions:
crbug.com/499104

[chromium-reviews, 2015-06-11 10:39:28]

This was already reverted quite some time ago.

On Wed, Jun 10, 2015 at 5:56 PM, <lushnikov@chromium.org> wrote:

> On 2015/05/05 00:28:19, mdempsky wrote:
>
>> This makes at least gmail, github, and my Chrome theme look anywhere from
>> bad
>>
> to
>
>> horrible on a 101dpi monitor. crbug.com/484400, crbug.com/484411,
>> crbug.com/484412
>>
>
> This change also makes Chrome DevTools to be blurred under certain
> conditions:
> crbug.com/499104
>
> https://codereview.chromium.org/1078423002/
>



-- 
Best regards,
Michael

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.