Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1084453002: Fixed segmentation fault. Because currently return null when call views::LinuxUI::instance(). (Closed)

Created:
5 years, 8 months ago by hyunjunekim2
Modified:
5 years, 8 months ago
Reviewers:
stapelberg, oshima, erg
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, tapted, reveman, sky, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Segmentation fault. Because currently return null when call views::LinuxUI::instance(). This CL is to fix Segmentation fault on content_shell. Because currently return null when call views::LinuxUI::instance(). So replace views::LinuxUI::instance()->GetDeviceScaleFactor() with GetDeviceScaleFactor(). Base OS:Ubuntu 14.04(64bit) BUG=476360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). this CL is to fix bug(476360). Could you check this ...
5 years, 8 months ago (2015-04-12 07:21:13 UTC) #2
tapted
+oshima/erg are probably the best reviewers for this, since they reviewed r324782. Moving everyone else ...
5 years, 8 months ago (2015-04-12 23:34:35 UTC) #4
hyunjunekim2
On 2015/04/12 23:34:35, tapted wrote: > +oshima/erg are probably the best reviewers for this, since ...
5 years, 8 months ago (2015-04-13 10:17:08 UTC) #5
stapelberg
The fix LGTM, but I’m not sure how best to proceed, given that the code ...
5 years, 8 months ago (2015-04-13 10:32:56 UTC) #7
stapelberg
On 2015/04/13 10:32:56, stapelberg wrote: > The fix LGTM, but I’m not sure how best ...
5 years, 8 months ago (2015-04-13 10:33:16 UTC) #8
hyunjunekim2
5 years, 8 months ago (2015-04-13 12:01:19 UTC) #9
Message was sent while issue was closed.
On 2015/04/13 10:33:16, stapelberg wrote:
> On 2015/04/13 10:32:56, stapelberg wrote:
> > The fix LGTM, but I’m not sure how best to proceed, given that the code in
> > question was rolled back. Unless anyone objects, I’ll send a CL which
re-adds
> it
> > with this fix.
> 
> Ah, I see this issue is already closed. Nevermind :).

stapelberg, Thank you for your review. ;)

Powered by Google App Engine
This is Rietveld 408576698