Use GetProperty for getting elements.

Use GetProperty for getting elements.

This also fixes issues with
- kMaxUint32 being a valid length but not index cornercases
- exotic integer objects masking "exotic indexes" even though its in the prototype chain
- concating of holey sloppy arguments

BUG=v8:4137
LOG=n

Committed: https://crrev.com/2fb894fa586485adbf8aec3a6101b6dd35573002
Cr-Commit-Position: refs/heads/master@{#28754}

[Toon Verwaest, 2015-05-22 17:11:53]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2015-05-22 17:12:24]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-05-22 17:16:48]

Patchset #1 (id:20001) has been deleted

[Toon Verwaest, 2015-05-22 17:16:57]

Patchset #1 (id:40001) has been deleted

[Toon Verwaest, 2015-05-22 17:25:44]

Patchset #1 (id:60001) has been deleted

[Toon Verwaest, 2015-05-22 17:36:17]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org
- jkummerow@chromium.org

[Toon Verwaest, 2015-05-22 17:36:18]

PTAL

[Igor Sheludko, 2015-05-26 17:11:56]

https://codereview.chromium.org/1159433003/diff/140001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1159433003/diff/140001/src/elements.cc#newcod...
src/elements.cc:1643: return index;
I think we should not break this invariant:
DCHECK_EQ(key, GetKeyForIndexImpl(parameters, GetIndexForKeyImpl(parameters,
key));

Currently we don't convert keys to indices and back, but if we ever do...

https://codereview.chromium.org/1159433003/diff/140001/src/elements.h
File src/elements.h (right):

https://codereview.chromium.org/1159433003/diff/140001/src/elements.h#newcode82
src/elements.h:82: inline MaybeHandle<AccessorPair>
GetAccessorPair(Handle<JSObject> holder,
nit: MUST_USE_RESULT ?

https://codereview.chromium.org/1159433003/diff/140001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1159433003/diff/140001/src/objects-inl.h#newc...
src/objects-inl.h:6525: CHECK(Object::cast(READ_FIELD(this,
kLengthOffset))->ToArrayIndex(&index));
ToArrayLength()?

[Toon Verwaest, 2015-05-27 10:06:25]

Addressed comments. I cannot support GetKeyForIndex in sloppy arguments objects
though. Marking it as unreachable instead.

https://codereview.chromium.org/1159433003/diff/140001/src/elements.h
File src/elements.h (right):

https://codereview.chromium.org/1159433003/diff/140001/src/elements.h#newcode82
src/elements.h:82: inline MaybeHandle<AccessorPair>
GetAccessorPair(Handle<JSObject> holder,
On 2015/05/26 17:11:56, Igor Sheludko wrote:
> nit: MUST_USE_RESULT ?

The MaybeHandle here means that there might not be an accessor, not that an
exception might be thrown. Hence MUST_USE_RESULT isn't necessary.

This method will go away soon anyway.

[Toon Verwaest, 2015-06-02 07:37:11]

Addressed all the comments now. (Also rebased.)
Now this CL additionally fixes enumerating sloppy mode arguments objects with
dictionary-mode backing stores.

[Igor Sheludko, 2015-06-02 09:36:41]

Nice solution! lgtm with a nit:

https://codereview.chromium.org/1159433003/diff/200001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1159433003/diff/200001/src/elements.cc#newcod...
src/elements.cc:1523: Object* key = dict->ValueAt(index);
dict->KeyAt(index) ? Just to be in sync the the surrounding code.

[Toon Verwaest, 2015-06-02 10:10:27]

Thanks. Addressed.

[Toon Verwaest, 2015-06-02 10:10:33]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-06-02 10:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1159433003/#ps220001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-06-02 10:10:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159433003/220001

[commit-bot: I haz the power, 2015-06-02 10:42:21]

Committed patchset #8 (id:220001)

[commit-bot: I haz the power, 2015-06-02 10:42:38]

Patchset 8 (id:??) landed as
https://crrev.com/2fb894fa586485adbf8aec3a6101b6dd35573002
Cr-Commit-Position: refs/heads/master@{#28754}