src/json-stringifier.h - Issue 1159433003: Use GetProperty for getting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index 9579c78ff0774f4c18ae8e3ca79b427b939ba57a..a28691503d12c7799ff3df9f0c99f130b211dd6b 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -439,7 +439,7 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSArray(

Result stack_push = StackPush(object);

if (stack_push != SUCCESS) return stack_push;

uint32_t length = 0;

- CHECK(object->length()->ToArrayIndex(&length));

+ CHECK(object->length()->ToArrayLength(&length));

builder_.AppendCharacter('[');

switch (object->GetElementsKind()) {

case FAST_SMI_ELEMENTS: {

« no previous file with comments | « src/json-parser.h ('k') | src/lookup.h » ('j') | no next file with comments »