src/utils.h - Issue 1159433003: Use GetProperty for getting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index d8879ac00b46fce28357da24a0bc52356674570f..8b2f1137e0fa708a0701440a048120aedf8ec2d8 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -1690,7 +1690,7 @@ bool StringToArrayIndex(Stream* stream, uint32_t* index) {

d = stream->GetNext() - '0';

if (d < 0 || d > 9) return false;

// Check that the new result is below the 32 bit limit.

- if (result > 429496729U - ((d > 5) ? 1 : 0)) return false;

+ if (result > 429496729U - ((d + 3) >> 3)) return false;

result = (result * 10) + d;

}

« no previous file with comments | « src/runtime/runtime-typedarray.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »