Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 11593011: Add a new code/message path for moving an insertion handle (Closed)

Created:
8 years ago by cjhopman
Modified:
7 years, 11 months ago
Reviewers:
palmer, Jay Civelli, jam
CC:
chromium-reviews, yusukes+watch_chromium.org, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a new code/message path for moving an insertion handle On Android, we've been using selectRange for moving an insertion handle. However, we don't really want the behavior of selectRange (for example, dragging an insertion handle outside of a text box should not actual do a "selectRange" on the position outside of the text box). The behavior that we want has been added to WebKit as WebFrame::moveCaretSelectionTowardsWindowPoint. This change introduces the code/message path from the Browser side InsertionHandleController to WebKit similar to the current SelectRange path. BUG=165244, 163979, 165661 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176454

Patch Set 1 #

Patch Set 2 : Rebase + function rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -19 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 5 chunks +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InsertionHandleTest.java View 1 7 chunks +146 lines, -17 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
A content/test/data/android/device_files/insertion_handle/input_text.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
jcivelli: */android/* brettw: content/renderer, contetn/browser/renderer_host palmer: IPC security-- content/common/
8 years ago (2012-12-17 18:30:58 UTC) #1
palmer
lgtm
8 years ago (2012-12-17 19:13:21 UTC) #2
Jay Civelli
LGTM for Android part
8 years ago (2012-12-17 19:29:16 UTC) #3
cjhopman
brettw, ptal for: content/renderer, content/browser/renderer_host
7 years, 11 months ago (2013-01-09 23:03:20 UTC) #4
cjhopman
jam@ for content/renderer, content/browser/renderer_host since brettw@ is OOO.
7 years, 11 months ago (2013-01-11 03:17:54 UTC) #5
jam
On 2013/01/11 03:17:54, cjhopman wrote: > jam@ for content/renderer, content/browser/renderer_host since brettw@ is OOO. lgtm
7 years, 11 months ago (2013-01-11 17:30:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11593011/14001
7 years, 11 months ago (2013-01-11 19:00:23 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 22:34:42 UTC) #8
Message was sent while issue was closed.
Change committed as 176454

Powered by Google App Engine
This is Rietveld 408576698