Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2340)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 11593011: Add a new code/message path for moving an insertion handle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + function rename Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index dde2382b64a7fc809889930c36146277395b7251..491e9a684d07c61e4f9365e0952eadd32bc5be29 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1682,7 +1682,7 @@ public class ContentViewCore implements MotionEventDelegate, NavigationClient {
@Override
public void setCursorPosition(int x, int y) {
if (mNativeContentViewCore != 0) {
- nativeSelectBetweenCoordinates(mNativeContentViewCore, x, y, x, y);
+ nativeMoveCaret(mNativeContentViewCore, x, y);
}
}
@@ -2480,6 +2480,8 @@ public class ContentViewCore implements MotionEventDelegate, NavigationClient {
private native void nativeSelectBetweenCoordinates(
int nativeContentViewCoreImpl, int x1, int y1, int x2, int y2);
+ private native void nativeMoveCaret(int nativeContentViewCoreImpl, int x, int y);
+
private native boolean nativeCanGoBack(int nativeContentViewCoreImpl);
private native boolean nativeCanGoForward(int nativeContentViewCoreImpl);
private native boolean nativeCanGoToOffset(int nativeContentViewCoreImpl, int offset);

Powered by Google App Engine
This is Rietveld 408576698