Expand VisualBench to a real benching tool

include/views/SkOSWindow_Unix.h

Index: include/views/SkOSWindow_Unix.h
diff --git a/include/views/SkOSWindow_Unix.h b/include/views/SkOSWindow_Unix.h
index 78670cde133003bccd9654bce0c6cb263266c8ee..261ffe4039d4ae7768c43bfd964633425add5a33 100644
--- a/include/views/SkOSWindow_Unix.h
+++ b/include/views/SkOSWindow_Unix.h
@@ -48,6 +48,7 @@ public:
 
     void setFullscreen(bool) override;
     void setVsync(bool) override;
+    void closeWindow() override;
 
 protected:
     // Overridden from from SkWindow:
@@ -64,7 +65,7 @@ private:
     void doPaint();
     void mapWindowAndWait();
 
-    void closeWindow();
+    void privateCloseWindow();

[bsalomon, 2015/06/01 13:49:54]

I think it is slightly more consistent with other code to call this internal
rather than private. Also, this seems pretty different than the new
closeWindow(). It might be helpful to have some comments.

Is it a problem that this is diverging from the other OS variants for this
class? I don't remember whether they are or need to be consistent.

[joshualitt, 2015/06/01 16:16:09]

ack
Not exactly sure what you mean.  All three of the calls I have added are general
methods which any backend SkOSWindow can implement.  In the longterm, I will try
and write implementations for atleast android and probably windows / mac.  Also,
there are other virtual methods on SkWindow with noop implementations.

[bsalomon, 2015/06/01 16:21:24]

ok, lgtm.

     void initWindow(int newMSAASampleCount, AttachmentInfo* info);
 
     SkUnixWindow fUnixWindow;