Expand VisualBench to a real benching tool

include/views/SkOSWindow_Unix.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkOSWindow_Unix_DEFINED
 #define SkOSWindow_Unix_DEFINED
 
@@ skipping 30 matching lines @@
     bool attach(SkBackEndTypes attachType, int msaaSampleCount, AttachmentInfo*);
     void detach();
     void present();
 
     int getMSAASampleCount() const { return fMSAASampleCount; }
 
     //static bool PostEvent(SkEvent* evt, SkEventSinkID, SkMSec delay);
 
     void setFullscreen(bool) override;
     void setVsync(bool) override;
+    void closeWindow() override;
 
 protected:
     // Overridden from from SkWindow:
     void onSetTitle(const char title[]) override;
 
 private:
     enum NextXEventResult {
         kContinue_NextXEventResult,
         kQuitRequest_NextXEventResult,
         kPaintRequest_NextXEventResult
     };
 
     NextXEventResult nextXEvent();
     void doPaint();
     void mapWindowAndWait();
 
-    void closeWindow();
+    void privateCloseWindow();

[bsalomon, 2015/06/01 13:49:54]

I think it is slightly more consistent with other code to call this internal
rather than private. Also, this seems pretty different than the new
closeWindow(). It might be helpful to have some comments.

Is it a problem that this is diverging from the other OS variants for this
class? I don't remember whether they are or need to be consistent.

[joshualitt, 2015/06/01 16:16:09]

ack
Not exactly sure what you mean.  All three of the calls I have added are general
methods which any backend SkOSWindow can implement.  In the longterm, I will try
and write implementations for atleast android and probably windows / mac.  Also,
there are other virtual methods on SkWindow with noop implementations.

[bsalomon, 2015/06/01 16:21:24]

ok, lgtm.

     void initWindow(int newMSAASampleCount, AttachmentInfo* info);
 
     SkUnixWindow fUnixWindow;
 
     // Needed for GL
     XVisualInfo* fVi;
     // we recreate the underlying xwindow if this changes
     int fMSAASampleCount;
 
     typedef SkWindow INHERITED;
 };
 
 #endif