Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1159083004: Speculative revert to fix ChromeOS PFQ mips builder (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
jonross, matthewyuan
CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@speciulative_mips_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative revert to fix ChromeOS PFQ mips builder The original change is suspected of breaking the build and the second one is followup that needs to be reverted along with it. Revert "Fix use of 'sysroot' variable in harfbuzz.gyp" https://codereview.chromium.org/1158283003 Revert "Fix common.gypi when run with target_arch=mips" https://codereview.chromium.org/1166523004 TBR=cpu BUG=496462 Committed: https://crrev.com/3f39737a0258d942440b9abe589f06c7305bfb77 Cr-Commit-Position: refs/heads/master@{#332766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -34 lines) Patch
M build/common.gypi View 8 chunks +28 lines, -34 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/libexif/libexif.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
5 years, 6 months ago (2015-06-04 00:57:18 UTC) #2
jonross
On 2015/06/04 00:57:18, Sam Clegg wrote: LGTM
5 years, 6 months ago (2015-06-04 01:36:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159083004/1
5 years, 6 months ago (2015-06-04 02:08:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 02:13:29 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 02:14:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f39737a0258d942440b9abe589f06c7305bfb77
Cr-Commit-Position: refs/heads/master@{#332766}

Powered by Google App Engine
This is Rietveld 408576698