Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1158283003: Fix use of 'sysroot' variable in harfbuzz.gyp (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use of 'sysroot' variable in harfbuzz.gyp The sysroot variable is set conditionally in common.gypi but not at the nesting level required for other conditional to depend on it like the one in hardbuzz does. This means that sysroot always appeared to be empty to harfbuzz.gyp, and hence the special handling for ARM linux was required. This change moves the setting of 'sysroot' up one level of nesting and defines 'pkg-config' in common.gypi so it can be shared. Second attempt at landing this. First attempt was here: https://codereview.chromium.org/1151753002 TBR=cpu Committed: https://crrev.com/fa36d7041817ddd299c89ca5ecef432c9210fda9 Cr-Commit-Position: refs/heads/master@{#332311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -89 lines) Patch
M build/common.gypi View 7 chunks +35 lines, -24 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/libexif/libexif.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Sam Clegg
This is a re-land of a previous CL (the chromite bug it exposed is now ...
5 years, 6 months ago (2015-05-29 21:43:30 UTC) #2
Dirk Pranke
rs lgtm.
5 years, 6 months ago (2015-05-29 21:50:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158283003/1
5 years, 6 months ago (2015-05-29 22:02:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 23:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158283003/1
5 years, 6 months ago (2015-06-01 21:19:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/23277)
5 years, 6 months ago (2015-06-01 23:44:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158283003/1
5 years, 6 months ago (2015-06-02 00:18:45 UTC) #13
cpu_(ooo_6.6-7.5)
rs lgtm
5 years, 6 months ago (2015-06-02 01:08:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 01:39:20 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 01:40:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa36d7041817ddd299c89ca5ecef432c9210fda9
Cr-Commit-Position: refs/heads/master@{#332311}

Powered by Google App Engine
This is Rietveld 408576698