Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1166523004: Fix common.gypi when run with target_arch=mips (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, jonross
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix common.gypi when run with target_arch=mips The CXX variable is already set later on in this file in make_global_settings. The mips build was broken by a recent CL: https://codereview.chromium.org/1158283003 TEST=GYP_DEFINES=target_arch=mipsel gyp_chromium && ninja -C out/Release chrome BUG=496273 Committed: https://crrev.com/15156343a810317288c08d176dd0cb26b75bb2bf Cr-Commit-Position: refs/heads/master@{#332689}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/common.gypi View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sam Clegg
5 years, 6 months ago (2015-06-03 19:29:49 UTC) #2
Sam Clegg
+dpranke for build/OWNERS
5 years, 6 months ago (2015-06-03 19:45:32 UTC) #4
jonross
On 2015/06/03 19:45:32, Sam Clegg wrote: > +dpranke for build/OWNERS LGTM
5 years, 6 months ago (2015-06-03 19:49:48 UTC) #5
Dirk Pranke
rubber-stamp lgtm.
5 years, 6 months ago (2015-06-03 20:05:02 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166523004/40001
5 years, 6 months ago (2015-06-03 20:07:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 21:14:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166523004/40001
5 years, 6 months ago (2015-06-03 21:23:41 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 21:29:12 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 21:30:06 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15156343a810317288c08d176dd0cb26b75bb2bf
Cr-Commit-Position: refs/heads/master@{#332689}

Powered by Google App Engine
This is Rietveld 408576698