ui/views/controls/webview/webview_interactive_uitest.cc - Issue 1159033008: Refactor ViewsDelegate singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/webview_interactive_uitest.cc

Issue 1159033008: Refactor ViewsDelegate singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/webview_interactive_uitest.cc

diff --git a/ui/views/controls/webview/webview_interactive_uitest.cc b/ui/views/controls/webview/webview_interactive_uitest.cc

index d8598184e176d356a2fdc8551b6af5b57eb19fba..3d0e4d73ed98486262ab404424fed42358888fbd 100644

--- a/ui/views/controls/webview/webview_interactive_uitest.cc

+++ b/ui/views/controls/webview/webview_interactive_uitest.cc

@@ -43,8 +43,7 @@ class WebViewInteractiveUiTest : public views::test::WidgetTest {

void SetUp() override {

gfx::GLSurface::InitializeOneOffForTests();

- // The ViewsDelegate is deleted when the ViewsTestBase class is torn down.

- WidgetTest::set_views_delegate(new WebViewTestViewsDelegate);

+ set_views_delegate(make_scoped_ptr(new WebViewTestViewsDelegate));

WidgetTest::SetUp();

}