Refactor ViewsDelegate singleton

ash/shell/content_client/shell_browser_main_parts.h

Index: ash/shell/content_client/shell_browser_main_parts.h
diff --git a/ash/shell/content_client/shell_browser_main_parts.h b/ash/shell/content_client/shell_browser_main_parts.h
index 89684315c50dd297913f874bc9d1850a028ca004..5f8add2a21aa81c5cef0eb0b7fa998082f4cced6 100644
--- a/ash/shell/content_client/shell_browser_main_parts.h
+++ b/ash/shell/content_client/shell_browser_main_parts.h
@@ -22,6 +22,10 @@ namespace net {
 class NetLog;
 }
 
+namespace views {
+class ViewsDelegate;
+}
+
 namespace wm {
 class WMState;
 }
@@ -54,6 +58,7 @@ class ShellBrowserMainParts : public content::BrowserMainParts {
   scoped_ptr<net::NetLog> net_log_;
   scoped_ptr<content::ShellBrowserContext> browser_context_;
   scoped_ptr<ash::shell::WindowWatcher> window_watcher_;
+  scoped_ptr<views::ViewsDelegate> views_delegate_;

[sky, 2015/06/08 20:22:42]

Seems like this should be before window_watcher_.

[mohsen, 2015/06/08 20:46:09]

Done, but is it because it is set before window_wathcer_ in the .cc file? Or
there is some other reason?

[sky, 2015/06/08 20:48:03]

I would think anything using ash many be using aura/views, and you really want
the delegate destroyed after that.

[mohsen, 2015/06/09 02:17:23]

I see. Now, I destroy the delegate in PostMainMessageLoopRun. Please take a
look...

   ShellDelegateImpl* delegate_;  // owned by Shell
   scoped_ptr<wm::WMState> wm_state_;