ui/views/controls/webview/webview.cc - Issue 1159033008: Refactor ViewsDelegate singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/webview.cc

Issue 1159033008: Refactor ViewsDelegate singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/webview.cc

diff --git a/ui/views/controls/webview/webview.cc b/ui/views/controls/webview/webview.cc

index a131905b7d68ee3d4179524028015891c9e24ea3..059540a6ca341b0906e44792598abae2a9995bb3 100644

--- a/ui/views/controls/webview/webview.cc

+++ b/ui/views/controls/webview/webview.cc

@@ -407,9 +407,9 @@ void WebView::NotifyMaybeTextInputClientAndAccessibilityChanged() {

content::WebContents* WebView::CreateWebContents(

content::BrowserContext* browser_context) {

content::WebContents* contents = NULL;

- if (ViewsDelegate::views_delegate) {

- contents = ViewsDelegate::views_delegate->CreateWebContents(

- browser_context, NULL);

+ if (ViewsDelegate::GetInstance()) {

+ contents =

+ ViewsDelegate::GetInstance()->CreateWebContents(browser_context, NULL);

}

if (!contents) {