Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1159033006: Refactoring: Replace boolean parameters with enum classes (Closed)

Created:
5 years, 6 months ago by hajimehoshi
Modified:
5 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Replace boolean parameters with enum classes This CL replaces boolean parameters with enum classes newly introduced. BUG=n/a TEST=n/a; no behavior change

Patch Set 1 #

Patch Set 2 : Rename enum classes #

Patch Set 3 : Rename values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
M Source/core/editing/StyledMarkupAccumulator.h View 1 2 2 chunks +17 lines, -4 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 1 2 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hajimehoshi
PTAL
5 years, 6 months ago (2015-06-02 03:42:32 UTC) #2
hajimehoshi
+tkent for core/xml
5 years, 6 months ago (2015-06-02 03:43:20 UTC) #4
yosin_UTC9
Could you split this patch into two patches? 1 SerializationType 2 RangeFullySelectsNode, IsBlock, AddDisplayInline How ...
5 years, 6 months ago (2015-06-02 03:47:04 UTC) #5
hajimehoshi
On 2015/06/02 03:47:04, Yosi_UTC9 wrote: > Could you split this patch into two patches? > ...
5 years, 6 months ago (2015-06-02 03:51:34 UTC) #6
hajimehoshi
On 2015/06/02 03:51:34, hajimehoshi wrote: > On 2015/06/02 03:47:04, Yosi_UTC9 wrote: > > Could you ...
5 years, 6 months ago (2015-06-02 03:58:25 UTC) #7
hajimehoshi
-tkent
5 years, 6 months ago (2015-06-02 03:58:39 UTC) #9
hajimehoshi
5 years, 6 months ago (2015-06-02 05:17:09 UTC) #10
This CL now includes changes only for RangeFullySelectsNode, IsBlock,
AddDisplayInline. PTAL

Powered by Google App Engine
This is Rietveld 408576698