Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: Source/core/editing/StyledMarkupAccumulator.h

Issue 1159033006: Refactoring: Replace boolean parameters with enum classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rename values Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2011 Igalia S.L. 4 * Copyright (C) 2011 Igalia S.L.
5 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 5 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 22 matching lines...) Expand all
33 #include "core/editing/MarkupAccumulator.h" 33 #include "core/editing/MarkupAccumulator.h"
34 #include "core/editing/TextOffset.h" 34 #include "core/editing/TextOffset.h"
35 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class Document; 39 class Document;
40 class StylePropertySet; 40 class StylePropertySet;
41 class Text; 41 class Text;
42 42
43 enum class RangeFullySelectsNode {
44 DoesSelect,
45 DoesNotSelect,
46 };
47
48 enum class StyleTagType {
49 Block,
50 Inline,
51 };
52
53 enum class AddDisplayInline {
54 DoesAdd,
55 DoesNotAdd,
56 };
57
43 class StyledMarkupAccumulator final { 58 class StyledMarkupAccumulator final {
44 WTF_MAKE_NONCOPYABLE(StyledMarkupAccumulator); 59 WTF_MAKE_NONCOPYABLE(StyledMarkupAccumulator);
45 STACK_ALLOCATED(); 60 STACK_ALLOCATED();
46 public: 61 public:
47 enum RangeFullySelectsNode { DoesFullySelectNode, DoesNotFullySelectNode };
48
49 StyledMarkupAccumulator(EAbsoluteURLs, const TextOffset& start, const TextOf fset& end, const PassRefPtrWillBeRawPtr<Document>, EAnnotateForInterchange, Node *); 62 StyledMarkupAccumulator(EAbsoluteURLs, const TextOffset& start, const TextOf fset& end, const PassRefPtrWillBeRawPtr<Document>, EAnnotateForInterchange, Node *);
50 63
51 void appendString(const String&); 64 void appendString(const String&);
52 void appendStartTag(Node&, Namespaces* = nullptr); 65 void appendStartTag(Node&, Namespaces* = nullptr);
53 void appendEndTag(const Element&); 66 void appendEndTag(const Element&);
54 void appendStartMarkup(StringBuilder&, Node&, Namespaces*); 67 void appendStartMarkup(StringBuilder&, Node&, Namespaces*);
55 void appendEndMarkup(StringBuilder&, const Element&); 68 void appendEndMarkup(StringBuilder&, const Element&);
56 69
57 void appendElement(StringBuilder&, Element&, Namespaces*); 70 void appendElement(StringBuilder&, Element&, Namespaces*);
58 void appendElement(StringBuilder&, Element&, bool, RangeFullySelectsNode); 71 void appendElement(StringBuilder&, Element&, AddDisplayInline, RangeFullySel ectsNode);
59 void appendStyleNodeOpenTag(StringBuilder&, StylePropertySet*, bool isBlock = false); 72 void appendStyleNodeOpenTag(StringBuilder&, StylePropertySet*, StyleTagType = StyleTagType::Inline);
60 73
61 // TODO(hajimehoshi): These functions are called from the serializer, but 74 // TODO(hajimehoshi): These functions are called from the serializer, but
62 // should not. 75 // should not.
63 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; } 76 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; }
64 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; } 77 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; }
65 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; } 78 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; }
66 79
67 size_t length() const { return m_accumulator.length(); } 80 size_t length() const { return m_accumulator.length(); }
68 void concatenateMarkup(StringBuilder&) const; 81 void concatenateMarkup(StringBuilder&) const;
69 82
(...skipping 12 matching lines...) Expand all
82 const TextOffset m_end; 95 const TextOffset m_end;
83 const RefPtrWillBeMember<Document> m_document; 96 const RefPtrWillBeMember<Document> m_document;
84 const EAnnotateForInterchange m_shouldAnnotate; 97 const EAnnotateForInterchange m_shouldAnnotate;
85 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized; 98 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized;
86 RefPtrWillBeMember<EditingStyle> m_wrappingStyle; 99 RefPtrWillBeMember<EditingStyle> m_wrappingStyle;
87 }; 100 };
88 101
89 } // namespace blink 102 } // namespace blink
90 103
91 #endif // StyledMarkupAccumulator_h 104 #endif // StyledMarkupAccumulator_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698