Source/modules/accessibility/AXObject.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Build fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObject.cpp

diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp

index a933bf17981fa5adfb7cf5be8118d4d103e62f79..ee1e4ad66972de2dfa42ef0291c791a0944a7aa9 100644

--- a/Source/modules/accessibility/AXObject.cpp

+++ b/Source/modules/accessibility/AXObject.cpp

@@ -1087,7 +1087,8 @@ void AXObject::setScrollOffset(const IntPoint& offset) const

if (!area)

return;

- area->setScrollPosition(DoublePoint(offset.x(), offset.y()));

+ // TODO(bokan): This should potentially be a UserScroll.

+ area->setScrollPosition(DoublePoint(offset.x(), offset.y()), ProgrammaticScroll);

}

« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp ('k') | Source/modules/accessibility/AXScrollbar.cpp » ('j') | no next file with comments »