Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Build fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerScrollableArea.h ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
index ec59c7f667330b9f89f24246243fb72b58c5b7f6..aec03b25f5885a757bafcb1410029f1ef6786655 100644
--- a/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp
@@ -357,12 +357,12 @@ int DeprecatedPaintLayerScrollableArea::scrollSize(ScrollbarOrientation orientat
return (orientation == HorizontalScrollbar) ? scrollDimensions.width() : scrollDimensions.height();
}
-void DeprecatedPaintLayerScrollableArea::setScrollOffset(const IntPoint& newScrollOffset)
+void DeprecatedPaintLayerScrollableArea::setScrollOffset(const IntPoint& newScrollOffset, ScrollType scrollType)
{
- setScrollOffset(DoublePoint(newScrollOffset));
+ setScrollOffset(DoublePoint(newScrollOffset), scrollType);
}
-void DeprecatedPaintLayerScrollableArea::setScrollOffset(const DoublePoint& newScrollOffset)
+void DeprecatedPaintLayerScrollableArea::setScrollOffset(const DoublePoint& newScrollOffset, ScrollType)
{
// Ensure that the dimensions will be computed if they need to be (for overflow:hidden blocks).
if (m_scrollDimensionsDirty)
@@ -612,16 +612,8 @@ void DeprecatedPaintLayerScrollableArea::scrollToOffset(const DoubleSize& scroll
cancelProgrammaticScrollAnimation();
DoubleSize newScrollOffset = clamp == ScrollOffsetClamped ? clampScrollOffset(scrollOffset) : scrollOffset;
if (newScrollOffset != adjustedScrollOffset()) {
- if (scrollBehavior == ScrollBehaviorAuto)
- scrollBehavior = scrollBehaviorStyle();
DoublePoint origin(scrollOrigin());
- if (scrollBehavior == ScrollBehaviorSmooth) {
- // FIXME: Make programmaticallyScrollSmoothlyToOffset take DoublePoint. crbug.com/243871.
- programmaticallyScrollSmoothlyToOffset(toFloatPoint(-origin + newScrollOffset));
- } else {
- // FIXME: Make scrollToOffsetWithoutAnimation take DoublePoint. crbug.com/414283.
- scrollToOffsetWithoutAnimation(toFloatPoint(-origin + newScrollOffset));
- }
+ ScrollableArea::setScrollPosition(-origin + newScrollOffset, ProgrammaticScroll, scrollBehavior);
}
}
@@ -642,7 +634,10 @@ void DeprecatedPaintLayerScrollableArea::updateAfterLayout()
if (originalScrollOffset != adjustedScrollOffset()) {
DoublePoint origin(scrollOrigin());
- scrollToOffsetWithoutAnimation(toFloatPoint(-origin + adjustedScrollOffset()));
+
+ // Call the base version here since calling this class' version will early because the
+ // offset itself hasn't changed, the scroll origin has.
+ ScrollableArea::setScrollPosition(-origin + adjustedScrollOffset(), ProgrammaticScroll);
}
bool hasHorizontalOverflow = this->hasHorizontalOverflow();
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerScrollableArea.h ('k') | Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698